Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(create-gatsby): some for init starter #28376

Merged
merged 4 commits into from
Dec 1, 2020
Merged

test(create-gatsby): some for init starter #28376

merged 4 commits into from
Dec 1, 2020

Conversation

mfrachet
Copy link
Contributor

Description

Adding some tests for init starter

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 30, 2020
@mfrachet mfrachet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 30, 2020
gillkyle
gillkyle previously approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little refactoring for getting the package manager, looks good to me 🙂

@mfrachet mfrachet force-pushed the mfrachet/test-init-starter branch 2 times, most recently from 9fb4667 to 45615bc Compare December 1, 2020 08:50
@mfrachet mfrachet merged commit 4d14e22 into master Dec 1, 2020
@mfrachet mfrachet deleted the mfrachet/test-init-starter branch December 1, 2020 12:37
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
test(create-gatsby): some for init starter (gatsbyjs#28376)
52dfc03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

@mxstbr mxstbr Awaiting requested review from mxstbr

@gillkyle gillkyle Awaiting requested review from gillkyle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfrachet @ascorbic @gillkyle